Previously, MemBio::get_buf called slice::from_raw_parts with a null-pointer, which violates the functions invariants, leading to undefined behavior. In debug builds this would produce an assertion failure. This is now fixed.
This project might be open to known security vulnerabilities, which can be prevented by tightening the version range of affected dependencies. Find detailed information at the bottom.
webapp(4 total, 2 outdated, 1 possibly insecure)
| Crate | Required | Latest | Status |
|---|---|---|---|
| diesel ⚠️ | ^1.4.8 | 2.2.4 | out of date |
| anyhow | ^1.0.51 | 1.0.93 | up to date |
| serde | ^1.0.147 | 1.0.214 | up to date |
| toml | ^0.5.8 | 0.8.19 | out of date |
webapp-backend(20 total, 10 outdated, 2 possibly insecure)
| Crate | Required | Latest | Status |
|---|---|---|---|
| actix | ^0.10.0 | 0.13.5 | out of date |
| actix-cors | ^0.5.4 | 0.7.0 | out of date |
| actix-files | ^0.5.0 | 0.6.6 | out of date |
| actix-web | ^3.3.2 | 4.9.0 | out of date |
| anyhow | ^1.0.51 | 1.0.93 | up to date |
| bytes | ^1.1.0 | 1.8.0 | up to date |
| clap | ^2.34.0 | 4.5.20 | out of date |
| diesel ⚠️ | ^1.4.8 | 2.2.4 | out of date |
| env_logger | ^0.9.0 | 0.11.5 | out of date |
| futures | ^0.3.25 | 0.3.31 | up to date |
| jsonwebtoken | ^7.2.0 | 9.3.0 | out of date |
| log | ^0.4.14 | 0.4.22 | up to date |
| num_cpus | ^1.13.0 | 1.16.0 | up to date |
| openssl ⚠️ | ^0.10.38 | 0.10.68 | maybe insecure |
| r2d2 | ^0.8.9 | 0.8.10 | up to date |
| serde | ^1.0.147 | 1.0.214 | up to date |
| serde_json | ^1.0.73 | 1.0.132 | up to date |
| thiserror | ^1.0.30 | 2.0.0 | out of date |
| url | ^2.2.2 | 2.5.3 | up to date |
| uuid | ^0.8.2 | 1.11.0 | out of date |
(4 total, 3 outdated)
| Crate | Required | Latest | Status |
|---|---|---|---|
| actix-http-test | ^2.1.0 | 3.2.0 | out of date |
| actix-http | ^2.2.1 | 3.9.0 | out of date |
| lazy_static | ^1.4.0 | 1.5.0 | up to date |
| reqwest | ^0.11.7 | 0.12.9 | out of date |
webapp-frontend(8 total, 3 outdated)
| Crate | Required | Latest | Status |
|---|---|---|---|
| anyhow | ^1.0.51 | 1.0.93 | up to date |
| log | ^0.4.14 | 0.4.22 | up to date |
| serde | ^1.0.147 | 1.0.214 | up to date |
| stdweb | ^0.4.20 | 0.4.20 | up to date |
| thiserror | ^1.0.30 | 2.0.0 | out of date |
| wasm-bindgen | ^0.2.78 | 0.2.95 | up to date |
| yew | ^0.17.4 | 0.21.0 | out of date |
| yew-router | ^0.16.0 | 0.18.0 | out of date |
(3 total, all up-to-date)
| Crate | Required | Latest | Status |
|---|---|---|---|
| anyhow | ^1.0.51 | 1.0.93 | up to date |
| sass-rs | ^0.2.2 | 0.2.2 | up to date |
| url | ^2.2.2 | 2.5.3 | up to date |
openssl: `MemBio::get_buf` has undefined behavior with empty buffersPreviously, MemBio::get_buf called slice::from_raw_parts with a null-pointer, which violates the functions invariants, leading to undefined behavior. In debug builds this would produce an assertion failure. This is now fixed.
diesel: Binary Protocol Misinterpretation caused by Truncating or Overflowing CastsThe following presentation at this year's DEF CON was brought to our attention on the Diesel Gitter Channel:
SQL Injection isn't Dead: Smuggling Queries at the Protocol Level
http://web.archive.org/web/20240812130923/https://media.defcon.org/DEF%20CON%2032/DEF%20CON%2032%20presentations/DEF%20CON%2032%20-%20Paul%20Gerste%20-%20SQL%20Injection%20Isn't%20Dead%20Smuggling%20Queries%20at%20the%20Protocol%20Level.pdf
(Archive link for posterity.) Essentially, encoding a value larger than 4GiB can cause the length prefix in the protocol to overflow, causing the server to interpret the rest of the string as binary protocol commands or other data.
It appears Diesel does perform truncating casts in a way that could be problematic, for example: https://github.com/diesel-rs/diesel/blob/ae82c4a5a133db65612b7436356f549bfecda1c7/diesel/src/pg/connection/stmt/mod.rs#L36
This code has existed essentially since the beginning,
so it is reasonable to assume that all published versions <= 2.2.2 are affected.
The prefered migration to the outlined problem is to update to a Diesel version newer than 2.2.2, which includes fixes for the problem.
As always, you should make sure your application is validating untrustworthy user input. Reject any input over 4 GiB, or any input that could encode to a string longer than 4 GiB. Dynamically built queries are also potentially problematic if it pushes the message size over this 4 GiB bound.
For web application backends, consider adding some middleware that limits the size of request bodies by default.
Diesel now uses #[deny] directives for the following Clippy lints:
to prevent casts that will lead to precision loss or other trunctations. Additionally we performed an audit of the relevant code.
A fix is included in the 2.2.3 release.