Affected versions of this crate did not properly verify ed25519 signatures. Any signature with a correct length was considered valid.
This allows an attacker to impersonate any node identity.
This project might be open to known security vulnerabilities, which can be prevented by tightening the version range of affected dependencies. Find detailed information at the bottom.
libp2p-websocket(9 total, 5 outdated, 2 possibly insecure)
| Crate | Required | Latest | Status |
|---|---|---|---|
| bytes | ^0.4 | 1.6.0 | out of date |
| futures | ^0.1 | 0.3.30 | out of date |
| libp2p-core ⚠️ | ^0.8.0 | 0.41.2 | out of date |
| log | ^0.4.1 | 0.4.21 | up to date |
| rw-stream-sink | ^0.1.1 | 0.4.0 | out of date |
| stdweb | ^0.4 | 0.4.20 | up to date |
| tokio-io | ^0.1 | 0.1.13 | up to date |
| wasm-bindgen | ^0.2.42 | 0.2.92 | up to date |
| websocket ⚠️ | ^0.22.2 | 0.27.1 | out of date |
(2 total, 2 outdated, 1 possibly insecure)
| Crate | Required | Latest | Status |
|---|---|---|---|
| libp2p-tcp | ^0.8.0 | 0.41.0 | out of date |
| tokio ⚠️ | ^0.1 | 1.37.0 | out of date |
libp2p-core: Failure to properly verify ed25519 signatures makes any signature validAffected versions of this crate did not properly verify ed25519 signatures. Any signature with a correct length was considered valid.
This allows an attacker to impersonate any node identity.
tokio: Data race when sending and receiving after closing a `oneshot` channelIf a tokio::sync::oneshot channel is closed (via the
oneshot::Receiver::close method), a data race may occur if the
oneshot::Sender::send method is called while the corresponding
oneshot::Receiver is awaited or calling try_recv.
When these methods are called concurrently on a closed channel, the two halves of the channel can concurrently access a shared memory location, resulting in a data race. This has been observed to cause memory corruption.
Note that the race only occurs when both halves of the channel are used
after the Receiver half has called close. Code where close is not used, or where the
Receiver is not awaited and try_recv is not called after calling close,
is not affected.
See tokio#4225 for more details.
websocket: Unbounded memory allocation based on untrusted lengthUntrusted websocket connections can cause an out-of-memory (OOM) process abort in a client or a server.
The root cause of the issue is during dataframe parsing.
Affected versions would allocate a buffer based on the declared dataframe size, which may come from an untrusted source.
When Vec::with_capacity fails to allocate, the default Rust allocator will abort the current process, killing all threads. This affects only sync (non-Tokio) implementation. Async version also does not limit memory, but does not use with_capacity, so DoS can happen only when bytes for oversized dataframe or message actually got delivered by the attacker.
This is a security concern for you, if
The crashes are fixed in version 0.26.5 by imposing default dataframe size limits. Affected users are advised to update to this version.
Note that default memory limits are rather large (100MB dataframes and 200 MB messages), so they can still cause DoS in some environments (i.e. 32-bit). New API has been added to fine tune those limits for specific applications.
This issue was reported by Evan Richter at ForAllSecure and found with Mayhem and Cargo Fuzz.