This project contains known security vulnerabilities. Find detailed information at the bottom.

Crate market-api-server

Dependencies

(16 total, 7 outdated, 2 insecure)

CrateRequiredLatestStatus
 warp^0.3.10.4.3out of date
 reqwest^0.11.30.13.5out of date
 sqlx ⚠️^0.5.70.9.0insecure
 log^0.4.80.4.34up to date
 env_logger^0.8.30.11.11out of date
 tokio^1.11.01.53.1up to date
 serde^1.0.1051.0.229up to date
 serde_json^1.0.501.0.151up to date
 dotenv^0.15.00.15.0up to date
 chrono^0.4.110.4.45up to date
 thiserror^1.0.142.0.21out of date
 flate2^1.0.141.1.10up to date
 dashmap^4.0.26.2.1out of date
 rust-embed ⚠️^5.5.18.12.0insecure
 percent-encoding^2.1.02.3.2up to date
 bytes^1.0.11.12.1up to date

Dev dependencies

(1 total, 1 outdated)

CrateRequiredLatestStatus
 serial_test^0.5.14.0.1out of date

Security Vulnerabilities

rust-embed: RustEmbed generated `get` method allows for directory traversal when reading files from disk

RUSTSEC-2021-0126

When running in debug mode and the debug-embed (off by default) feature is not enabled, the generated get method does not check that the input path is a child of the folder given.

This allows attackers to read arbitrary files in the file system if they have control over the filename given. The following code will print the contents of your /etc/passwd if adjusted with a correct number of ../s depending on where it is run from.

#[derive(rust_embed::RustEmbed)]
#[folder = "src/"]
pub struct Asset;

fn main() {
    let d = Asset::get("../../../etc/passwd").unwrap().data;
    println!("{}", String::from_utf8_lossy(&d));
}

The flaw was corrected by canonicalizing the input filename and ensuring that it starts with the canonicalized folder path.

sqlx: Binary Protocol Misinterpretation caused by Truncating or Overflowing Casts

RUSTSEC-2024-0363

The following presentation at this year's DEF CON was brought to our attention on the SQLx Discord:

SQL Injection isn't Dead: Smuggling Queries at the Protocol Level
http://web.archive.org/web/20240812130923/https://media.defcon.org/DEF%20CON%2032/DEF%20CON%2032%20presentations/DEF%20CON%2032%20-%20Paul%20Gerste%20-%20SQL%20Injection%20Isn't%20Dead%20Smuggling%20Queries%20at%20the%20Protocol%20Level.pdf
(Archive link for posterity.)

Essentially, encoding a value larger than 4GiB can cause the length prefix in the protocol to overflow, causing the server to interpret the rest of the string as binary protocol commands or other data.

It appears SQLx does perform truncating casts in a way that could be problematic, for example: https://github.com/launchbadge/sqlx/blob/6f2905695b9606b5f51b40ce10af63ac9e696bb8/sqlx-postgres/src/arguments.rs#L163

This code has existed essentially since the beginning, so it is reasonable to assume that all published versions <= 0.8.0 are affected.

Mitigation

As always, you should make sure your application is validating untrustworthy user input. Reject any input over 4 GiB, or any input that could encode to a string longer than 4 GiB. Dynamically built queries are also potentially problematic if it pushes the message size over this 4 GiB bound.

Encode::size_hint() can be used for sanity checks, but do not assume that the size returned is accurate. For example, the Json<T> and Text<T> adapters have no reasonable way to predict or estimate the final encoded size, so they just return size_of::<T>() instead.

For web application backends, consider adding some middleware that limits the size of request bodies by default.

Resolution

sqlx 0.8.1 has been released with the fix: https://github.com/launchbadge/sqlx/blob/main/CHANGELOG.md#081---2024-08-23

Postgres users are advised to upgrade ASAP as a possible exploit has been demonstrated: https://github.com/launchbadge/sqlx/issues/3440#issuecomment-2307956901

MySQL and SQLite do not appear to be exploitable, but upgrading is recommended nonetheless.