This project might be open to known security vulnerabilities, which can be prevented by tightening the version range of affected dependencies. Find detailed information at the bottom.

Crate lemmy_db_schema

Dependencies

(31 total, 9 outdated, 1 possibly insecure)

CrateRequiredLatestStatus
 activitypub_federation^0.5.100.6.5out of date
 anyhow^1.0.861.0.100up to date
 async-trait^0.1.880.1.89up to date
 bcrypt^0.15.10.17.1out of date
 chrono^0.4.410.4.42up to date
 deadpool^0.12.20.12.3up to date
 derive-new^0.7.00.7.0up to date
 diesel ⚠️^2.1.62.3.4maybe insecure
 diesel-async^0.4.10.7.4out of date
 diesel-derive-enum^2.1.02.1.0up to date
 diesel-derive-newtype^2.1.22.1.2up to date
 diesel_ltree^0.3.10.4.0out of date
 diesel_migrations^2.1.02.3.1up to date
 futures-util^0.3.310.3.31up to date
 i-love-jesus^0.1.00.3.0out of date
 lemmy_utils=0.19.120.19.12up to date
 moka^0.12.100.12.11up to date
 regex^1.11.11.12.2up to date
 rustls^0.23.270.23.35up to date
 serde^1.0.2191.0.228up to date
 serde_json^1.0.1401.0.145up to date
 serde_with^3.12.03.16.1up to date
 strum^0.26.30.27.2out of date
 tokio^1.45.01.48.0up to date
 tokio-postgres^0.7.130.7.15up to date
 tokio-postgres-rustls^0.12.00.13.0out of date
 tracing^0.1.410.1.43up to date
 ts-rs^7.1.111.1.0out of date
 typed-builder^0.19.10.23.2out of date
 url^2.5.22.5.7up to date
 uuid^1.10.01.18.1up to date

Dev dependencies

(2 total, all up-to-date)

CrateRequiredLatestStatus
 pretty_assertions^1.4.11.4.1up to date
 serial_test^3.2.03.2.0up to date

Security Vulnerabilities

diesel: Binary Protocol Misinterpretation caused by Truncating or Overflowing Casts

RUSTSEC-2024-0365

The following presentation at this year's DEF CON was brought to our attention on the Diesel Gitter Channel:

SQL Injection isn't Dead: Smuggling Queries at the Protocol Level
http://web.archive.org/web/20240812130923/https://media.defcon.org/DEF%20CON%2032/DEF%20CON%2032%20presentations/DEF%20CON%2032%20-%20Paul%20Gerste%20-%20SQL%20Injection%20Isn't%20Dead%20Smuggling%20Queries%20at%20the%20Protocol%20Level.pdf
(Archive link for posterity.) Essentially, encoding a value larger than 4GiB can cause the length prefix in the protocol to overflow, causing the server to interpret the rest of the string as binary protocol commands or other data.

It appears Diesel does perform truncating casts in a way that could be problematic, for example: https://github.com/diesel-rs/diesel/blob/ae82c4a5a133db65612b7436356f549bfecda1c7/diesel/src/pg/connection/stmt/mod.rs#L36

This code has existed essentially since the beginning, so it is reasonable to assume that all published versions <= 2.2.2 are affected.

Mitigation

The prefered migration to the outlined problem is to update to a Diesel version newer than 2.2.2, which includes fixes for the problem.

As always, you should make sure your application is validating untrustworthy user input. Reject any input over 4 GiB, or any input that could encode to a string longer than 4 GiB. Dynamically built queries are also potentially problematic if it pushes the message size over this 4 GiB bound.

For web application backends, consider adding some middleware that limits the size of request bodies by default.

Resolution

Diesel now uses #[deny] directives for the following Clippy lints:

to prevent casts that will lead to precision loss or other trunctations. Additionally we performed an audit of the relevant code.

A fix is included in the 2.2.3 release.